Tagging @crazoes, I cannot add you as a reviewer for some unknown github reason

Jenkins known issues.

Tagging @crazoes, I cannot add you as a reviewer for some unknown github reason

When users are marked as Contributor, you cannot assign them. You can assign users with status Member. I think only @lgirdwood can add members, so you need to contact him.

When users are marked as Contributor, you cannot assign them. You can assign users with status Member

You sound like the first person I met who understand github's permissions :-) Have you found any other documentation than the pages below? They don't define Contributor or Member roles and they don't seem to mention who can be a Reviewer either...

https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization
https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/permission-levels-for-an-organization
https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository

@marc-hb thesofproject has is an organization in which we can be members, that will give the Member role. I for example am in the sof-developers team of this project, which has write access to this repo and the others from thesofproject. This means I can edit your comments, give reviews that count towards mergeability etc -- everything on the Write permission.

Member simply means that I'm a member of the organization, probably this means member of one of its teams.

I think someone needs to add you to the sof-developers team in order to be able to review.

I think someone needs to add you to the sof-developers team in order to be able to review.

Do you mean adding not me but @crazoes to sof-developers because only sof-developers can be in the reviewers in the top-right corner of a PR?
I can already add (other) reviewers, I've been doing it for some time now.

I think someone needs to add you to the sof-developers team in order to be able to review.

Do you mean adding not me but @crazoes to sof-developers because only sof-developers can be in the reviewers in the top-right corner of a PR?
I can already add (other) reviewers, I've been doing it for some time now.

I did mean her, guess my wording was kinda ambiguous.

PR #2710 fixes ./scripts/build-tools.sh -t -f too.

When users are marked as Contributor, you cannot assign them. You can assign users with status Member

You sound like the first person I met who understand github's permissions :-) Have you found any other documentation than the pages below? They don't define Contributor or Member roles and they don't seem to mention who can be a Reviewer either...

https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization
https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/permission-levels-for-an-organization
https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository

Github doc is generally ok, but it's still lacking most of thing. I just figured out this stuff, by looking how it works ;p
The links that you pasted apply for people that are already in organizations.